d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Speed up freebsd-update IDS by using IFS to split fields instead of

Browse Source 
forking lots of processes to run echo|cut.  In one test this reduced
the CPU time from 980s to 134s and the wallclock time from 806s to
132s.

Submitted by:	Oleg Ginzburg
This commit is contained in:
Colin Percival 2013-10-16 08:19:58 +00:00
parent 348298b1a3
commit aa60062e00
1 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
usr.sbin/freebsd-update/freebsd-update.sh
View File

@ -3033,21 +3033,8 @@ IDS_compare () {
mv INDEX-NOTMATCHING.tmp INDEX-NOTMATCHING
# Go through the lines and print warnings.
while read LINE; do
FPATH=`echo "${LINE}" | cut -f 1 -d '|'`
TYPE=`echo "${LINE}" | cut -f 2 -d '|'`
OWNER=`echo "${LINE}" | cut -f 3 -d '|'`
GROUP=`echo "${LINE}" | cut -f 4 -d '|'`
PERM=`echo "${LINE}" | cut -f 5 -d '|'`
HASH=`echo "${LINE}" | cut -f 6 -d '|'`
LINK=`echo "${LINE}" | cut -f 7 -d '|'`
P_TYPE=`echo "${LINE}" | cut -f 8 -d '|'`
P_OWNER=`echo "${LINE}" | cut -f 9 -d '|'`
P_GROUP=`echo "${LINE}" | cut -f 10 -d '|'`
P_PERM=`echo "${LINE}" | cut -f 11 -d '|'`
P_HASH=`echo "${LINE}" | cut -f 12 -d '|'`
P_LINK=`echo "${LINE}" | cut -f 13 -d '|'`
local IFS='|'
while read FPATH TYPE OWNER GROUP PERM HASH LINK P_TYPE P_OWNER P_GROUP P_PERM P_HASH P_LINK; do
# Warn about different object types.
if ! [ "${TYPE}" = "${P_TYPE}" ]; then
echo -n "${FPATH} is a "