From ab0eee55638f4ed525b6a81b05f44e039d01c548 Mon Sep 17 00:00:00 2001 From: John Baldwin Date: Thu, 17 Apr 2003 22:14:30 +0000 Subject: [PATCH] Protect p_flag with the proc lock. The sched_lock is not needed to turn off P_STOPPED_SIG in p_flag. --- sys/fs/procfs/procfs_ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/fs/procfs/procfs_ctl.c b/sys/fs/procfs/procfs_ctl.c index 672704027017..ff4fb0adc1d3 100644 --- a/sys/fs/procfs/procfs_ctl.c +++ b/sys/fs/procfs/procfs_ctl.c @@ -263,8 +263,8 @@ out: * or some other trap. */ case PROCFS_CTL_RUN: - PROC_UNLOCK(p); p->p_flag &= ~P_STOPPED_SIG; /* this uses SIGSTOP */ + PROC_UNLOCK(p); break; /* @@ -349,9 +349,9 @@ procfs_doprocctl(PFS_FILL_ARGS) /* XXXKSE: */ FIX_SSTEP(FIRST_THREAD_IN_PROC(p)); #endif - mtx_lock_spin(&sched_lock); /* XXXKSE: */ p->p_flag &= ~P_STOPPED_SIG; + mtx_lock_spin(&sched_lock); thread_unsuspend(p); mtx_unlock_spin(&sched_lock); } else