d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sh: Explain duplicate tcsetpgrp() calls

Browse Source 
This is a comment change only.
This commit is contained in:
Jilles Tjoelker 2020-12-26 15:27:33 +01:00
parent b63eeef41f
commit ab41d7f371
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bin/sh/jobs.c
View File

@ -928,7 +928,12 @@ forkshell(struct job *jp, union node *n, int mode)
pgrp = jp->ps[0].pid; pgrp = jp->ps[0].pid;
if (setpgid(0, pgrp) == 0 && mode == FORK_FG && if (setpgid(0, pgrp) == 0 && mode == FORK_FG &&
ttyfd >= 0) { ttyfd >= 0) {
/*** this causes superfluous TIOCSPGRPS ***/ /*
* Each process in a pipeline must have the tty
* pgrp set before running its code.
* Only for pipelines of three or more processes
* could this be reduced to two calls.
*/
if (tcsetpgrp(ttyfd, pgrp) < 0) if (tcsetpgrp(ttyfd, pgrp) < 0)
error("tcsetpgrp failed, errno=%d", errno); error("tcsetpgrp failed, errno=%d", errno);
} }