d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix two possible (but unlikely) NULL-pointer dereferences in glxsb(4).

Browse Source 
Spotted by:	Coverity
MFC after:	1 week
This commit is contained in:
philip 2008-11-17 07:09:40 +00:00
parent 1f631eadf5
commit acf5df9093
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/dev/glxsb/glxsb.c
View File

@ -358,7 +358,8 @@ glxsb_detach(device_t dev)
return (EBUSY);
}
}
while ((ses = TAILQ_FIRST(&sc->sc_sessions)) != NULL) {
while (!TAILQ_EMPTY(&sc->sc_sessions)) {
ses = TAILQ_FIRST(&sc->sc_sessions);
TAILQ_REMOVE(&sc->sc_sessions, ses, ses_next);
free(ses, M_GLXSB);
}
@ -867,8 +868,11 @@ glxsb_crypto_process(device_t dev, struct cryptop *crp, int hint)
enccrd = maccrd = NULL;
if (crp == NULL ||
crp->crp_callback == NULL || crp->crp_desc == NULL) {
/* Sanity check. */
if (crp == NULL)
return (EINVAL);
if (crp->crp_callback == NULL || crp->crp_desc == NULL) {
error = EINVAL;
goto fail;
}