From ad58e5e86c78c97275f1c47c75b66e20d6250144 Mon Sep 17 00:00:00 2001 From: Mateusz Guzik Date: Sat, 17 Feb 2018 09:03:11 +0000 Subject: [PATCH] exit: stop doing PROC_SLOCK just to call proc_reap It immediately does PROC_SUNLOCK anyway and the lock plays no role. --- sys/kern/kern_exit.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c index 05d05c6932c1..b063bda5b7ff 100644 --- a/sys/kern/kern_exit.c +++ b/sys/kern/kern_exit.c @@ -817,12 +817,10 @@ proc_reap(struct thread *td, struct proc *p, int *status, int options) sx_assert(&proctree_lock, SA_XLOCKED); PROC_LOCK_ASSERT(p, MA_OWNED); - PROC_SLOCK_ASSERT(p, MA_OWNED); KASSERT(p->p_state == PRS_ZOMBIE, ("proc_reap: !PRS_ZOMBIE")); q = td->td_proc; - PROC_SUNLOCK(p); if (status) *status = KW_EXITCODE(p->p_xexit, p->p_xsig); if (options & WNOWAIT) { @@ -1090,7 +1088,6 @@ proc_to_reap(struct thread *td, struct proc *p, idtype_t idtype, id_t id, } if (p->p_state == PRS_ZOMBIE && !check_only) { - PROC_SLOCK(p); proc_reap(td, p, status, options); return (-1); }