d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move a call to cam_freeccb() to avoid a use after free error and

Browse Source 
a later double free.

Reported by:	Coverity
CID:		1018507
MFC after:	1 week
This commit is contained in:
Don Lewis 2016-05-13 06:26:42 +00:00
parent 090fc1c839
commit ae092f753a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.sbin/mptutil/mpt_cam.c
View File

@ -260,7 +260,6 @@ fetch_scsi_capacity(struct cam_device *dev, struct mpt_standalone_disk *disk)
cam_freeccb(ccb); cam_freeccb(ccb);
return (EIO); return (EIO);
} }
cam_freeccb(ccb);
/* /*
* A last block of 2^32-1 means that the true capacity is over 2TB, * A last block of 2^32-1 means that the true capacity is over 2TB,
@ -269,6 +268,7 @@ fetch_scsi_capacity(struct cam_device *dev, struct mpt_standalone_disk *disk)
*/ */
if (scsi_4btoul(rcap.addr) != 0xffffffff) { if (scsi_4btoul(rcap.addr) != 0xffffffff) {
disk->maxlba = scsi_4btoul(rcap.addr); disk->maxlba = scsi_4btoul(rcap.addr);
cam_freeccb(ccb);
return (0); return (0);
} }