Limit the number of mbufs that can be allocated for IPV6_2292PKTOPTIONS

(and IPV6_PKTOPTIONS).

PR:		100219
Submitted by:	Joseph Kong
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D5157
This commit is contained in:
George V. Neville-Neil 2016-10-17 23:25:31 +00:00
parent 3239d65238
commit aec9c8d5a5

View File

@ -1393,6 +1393,15 @@ ip6_ctloutput(struct socket *so, struct sockopt *sopt)
int retval;
#endif
/*
* Don't use more than a quarter of mbuf clusters. N.B.:
* nmbclusters is an int, but nmbclusters * MCLBYTES may overflow
* on LP64 architectures, so cast to u_long to avoid undefined
* behavior. ILP32 architectures cannot have nmbclusters
* large enough to overflow for other reasons.
*/
#define IPV6_PKTOPTIONS_MBUF_LIMIT ((u_long)nmbclusters * MCLBYTES / 4)
level = sopt->sopt_level;
op = sopt->sopt_dir;
optname = sopt->sopt_name;
@ -1448,6 +1457,12 @@ ip6_ctloutput(struct socket *so, struct sockopt *sopt)
{
struct mbuf *m;
if (optlen > IPV6_PKTOPTIONS_MBUF_LIMIT) {
printf("ip6_ctloutput: mbuf limit hit\n");
error = ENOBUFS;
break;
}
error = soopt_getm(sopt, &m); /* XXX */
if (error != 0)
break;