d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sfxge(4): handle negative ticks difference correctly

Browse Source 
ticks are signed int and if statistics is not updated for a long time
(more than INT_MAX ticks, but less than UINT_MAX) difference becomes
negative and less than hz for a long time.

Other option to repeat is simply load driver (which initializes
timestamps to 0) when ticks are negative.

Sponsored by:   Solarflare Communications, Inc.
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D6777
This commit is contained in:
Andrew Rybchenko 2016-06-09 12:29:03 +00:00
parent aede1e09cf
commit af58aa462e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/dev/sfxge/sfxge_ev.c
View File

@ -453,7 +453,7 @@ sfxge_ev_stat_update(struct sfxge_softc *sc)
goto out;
now = ticks;
if (now - sc->ev_stats_update_time < hz)
if ((unsigned int)(now - sc->ev_stats_update_time) < (unsigned int)hz)
goto out;
sc->ev_stats_update_time = now;

4
sys/dev/sfxge/sfxge_port.c
View File

@ -62,7 +62,7 @@ sfxge_mac_stat_update(struct sfxge_softc *sc)
}
now = ticks;
if (now - port->mac_stats.update_time < hz) {
if ((unsigned int)(now - port->mac_stats.update_time) < (unsigned int)hz) {
rc = 0;
goto out;
}
@ -570,7 +570,7 @@ sfxge_phy_stat_update(struct sfxge_softc *sc)
}
now = ticks;
if (now - port->phy_stats.update_time < hz) {
if ((unsigned int)(now - port->phy_stats.update_time) < (unsigned int)hz) {
rc = 0;
goto out;
}