From b1b73fc4c9924c4ca2f94b76155a0895373a0b5c Mon Sep 17 00:00:00 2001 From: Don Lewis Date: Wed, 25 May 2016 05:20:34 +0000 Subject: [PATCH] Fix Coverity CID 1019054 (String not null terminated) in setfacl. Increase the size of buf[] by one to allow room for a NUL character at the end. Reported by: Coverity CID: 1019054 MFC after: 1 week --- bin/setfacl/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/setfacl/file.c b/bin/setfacl/file.c index c44f398196fd..e5e19a24773a 100644 --- a/bin/setfacl/file.c +++ b/bin/setfacl/file.c @@ -43,7 +43,7 @@ acl_t get_acl_from_file(const char *filename) { FILE *file; - char buf[BUFSIZ]; + char buf[BUFSIZ+1]; if (filename == NULL) err(1, "(null) filename in get_acl_from_file()"); @@ -61,7 +61,7 @@ get_acl_from_file(const char *filename) err(1, "fopen() %s failed", filename); } - fread(buf, sizeof(buf), (size_t)1, file); + fread(buf, sizeof(buf) - 1, (size_t)1, file); if (ferror(file) != 0) { fclose(file); err(1, "error reading from %s", filename);