d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Feedback from commit r284535

Browse Source 
davide:  imgact_binmisc_clear_entry() needs to use atomic ops to remove
the enable bit.

kib:  M_NOWAIT is not warranted and comment is invalid.
This commit is contained in:
sbruno 2015-06-19 18:57:36 +00:00
parent 3f96a9d528
commit b3c208462f
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/kern/imgact_binmisc.c
View File

@ -317,7 +317,7 @@ imgact_binmisc_disable_entry(char *name)
return (ENOENT);
}
ibe->ibe_flags &= ~IBF_ENABLED;
atomic_clear_32(&ibe->ibe_flags, IBF_ENABLED);
sx_sunlock(&interp_list_sx);
return (0);
@ -406,8 +406,7 @@ imgact_binmisc_get_all_entries(struct sysctl_req *req)
sx_slock(&interp_list_sx);
count = interp_list_entry_count;
/* Don't block in malloc() while holding lock. */
xbe = malloc(sizeof(*xbe) * count, M_BINMISC, M_NOWAIT|M_ZERO);
xbe = malloc(sizeof(*xbe) * count, M_BINMISC, M_ZERO);
if (!xbe) {
sx_sunlock(&interp_list_sx);
return (ENOMEM);