d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFC revision 1.181

Browse Source 
When breaking up a large request into smaller ones for the strategy
	routine, create all the child bio objects before starting the
	requests, rather than starting them as created. This closes a race
	whereby some number of child operations could complete before the
	rest were ever created, and prematurely freeing the parent bio.
	This fixes the panics installing in VMWare and qemu

Approved by: re (scottl@)
This commit is contained in:
peadar 2005-10-09 21:24:11 +00:00
parent 29c6215782
commit b6a59515a1
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/dev/ata/atapi-cd.c
View File

@ -760,7 +760,7 @@ acd_geom_start(struct bio *bp)
}
else {
u_int pos, size = cdp->iomax - cdp->iomax % bp->bio_to->sectorsize;
struct bio *bp2;
struct bio *bp2, *first, **next = &first;
for (pos = 0; pos < bp->bio_length; pos += size) {
if (!(bp2 = g_clone_bio(bp))) {
@ -773,6 +773,12 @@ acd_geom_start(struct bio *bp)
bp2->bio_data += pos;
bp2->bio_length = MIN(size, bp->bio_length - pos);
bp2->bio_pblkno = bp2->bio_offset / bp2->bio_to->sectorsize;
*next = bp2;
next = (struct bio **)&bp2->bio_driver1;
}
*next = NULL;
while ((bp2 = first) != NULL) {
first = (struct bio *)bp2->bio_driver1;
acd_strategy(bp2);
}
}