d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only delete the route if arplookup() tried to create it. Do not delete

Browse Source 
RTF_STATIC routes. Do not check for RTF_HOST so as to avoid being DoSed
when an RTF_GENMASK route exists in the table.

Add a more verbose comment about exactly what this code does.

Submitted by:	ru
This commit is contained in:
Bruce M Simpson 2003-10-03 09:19:23 +00:00
parent 43039b7df5
commit b75bead1f2
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sys/netinet/if_ether.c
View File

@ -921,16 +921,21 @@ arplookup(addr, create, proxy)
why = "gateway route is not ours";
if (why) {
if (create)
if (create) {
log(LOG_DEBUG, "arplookup %s failed: %s\n",
inet_ntoa(sin.sin_addr), why);
/* If there are no references to this route, purge it */
if (rt->rt_refcnt <= 0 && (rt->rt_flags & RTF_WASCLONED)) {
rtrequest(RTM_DELETE,
(struct sockaddr *)rt_key(rt),
rt->rt_gateway, rt_mask(rt),
rt->rt_flags, 0);
/*
* If there are no references to this Layer 2 route,
* and it is a cloned route, and not static, and
* arplookup() is creating the route, then purge
* it from the routing table as it is probably bogus.
*/
if (((rt->rt_flags & (RTF_STATIC | RTF_WASCLONED)) ==
RTF_WASCLONED) && (rt->rt_refcnt == 0))
rtrequest(RTM_DELETE,
(struct sockaddr *)rt_key(rt),
rt->rt_gateway, rt_mask(rt),
rt->rt_flags, 0);
}
return (0);
}