Tweaks to the beri boot loader so that it builds w/o warnings.

Sponsored by: Netflix

stand/mips/beri/boot2/Makefile

@@ -47,9 +47,7 @@ MAN=
 
 AFLAGS=		-G0
 
-CFLAGS+=	-I${.CURDIR}			\
-		-I${LDRSRC}			\
-		-D_KERNEL			\
+CFLAGS+=	-I${LDRSRC}			\
 		-Wall				\
 		-G0 				\
 		-fno-pic -mno-abicalls		\

stand/mips/beri/boot2/boot2.c

@@ -500,7 +500,7 @@ parse()
 		 */
 		unit = q[len-1];
 		if (unit < '0' || unit > '9') {
-		    printf("Invalid device: invalid unit\n", q,
+		    printf("Invalid device: invalid unit %c\n",
 		      unit);
 		    return (-1);
 		}

stand/mips/beri/common/altera_jtag_uart.c

@@ -130,13 +130,6 @@ uart_control_write(uint32_t v)
 	    ALTERA_JTAG_UART_DATA_OFF), v);
 }
 
-static int
-uart_writable(void)
-{
-
-	return ((uart_control_read() & ALTERA_JTAG_UART_CONTROL_WSPACE) != 0);
-}
-
 static int
 uart_readable(void)
 {

stand/mips/beri/loader/Makefile

@@ -67,7 +67,7 @@ SRCS+=		altera_jtag_uart.c				\
 # Since we don't have a backward compatibility issue, default to this on BERI.
 CFLAGS+=	-DBOOT_PROMPT_123
 
-HELP_FILES+=	help.mips
+HELP_FILES+=	${.CURDIR}/help.mips
 
 # Always add MI sources
 .include	"${BOOTSRC}/loader.mk"

stand/mips/beri/loader/devicename.c

@@ -88,7 +88,7 @@ beri_arch_parsedev(struct disk_devdesc **dev, const char *devspec,
     struct disk_devdesc *idev;
     struct devsw	*dv;
     int			i, unit, err;
-    const char		*cp;
+    char		*cp;
     const char		*np;
 
     /* minimum length check */
@@ -130,8 +130,10 @@ beri_arch_parsedev(struct disk_devdesc **dev, const char *devspec,
 		goto fail;
 	    }
 	} else {
-		cp = np;
+	    err = EUNIT;
+	    goto fail;
 	}
+
 	if (*cp && (*cp != ':')) {
 	    err = EINVAL;
 	    goto fail;

stand/mips/beri/loader/exec.c

@@ -119,7 +119,7 @@ beri_elf64_exec(struct preloaded_file *fp)
 	 * least bootinfop.
 	 */
 	(*entry)(boot2_argc, (register_t)boot2_argv, (register_t)boot2_envv,
-	    &bootinfo);
+	    (register_t)&bootinfo);
 
 	panic("exec returned");
 }

stand/mips/beri/loader/loader.h

@@ -41,6 +41,7 @@ extern struct devsw	 beri_cfi_disk;
 extern struct devsw	 beri_sdcard_disk;
 
 /* devicename.c */
+struct env_var;
 int	 beri_arch_setcurrdev(struct env_var *, int, const void *);
 char	*beri_arch_fmtdev(void *);
 int	 beri_arch_getdev(void **, const char *, const char **);