d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't access fs->first_object after dropping reference to it.

Browse Source 
The result could be a missed or extra giant unlock.

Reviewed by:	alc
This commit is contained in:
Tor Egge 2005-12-20 12:27:59 +00:00
parent 7881e1ee07
commit b898bb1be3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/vm/vm_fault.c
View File

@ -152,6 +152,7 @@ unlock_map(struct faultstate *fs)
static void
unlock_and_deallocate(struct faultstate *fs)
{
boolean_t firstobjneedgiant;
vm_object_pip_wakeup(fs->object);
VM_OBJECT_UNLOCK(fs->object);
@ -164,6 +165,7 @@ unlock_and_deallocate(struct faultstate *fs)
VM_OBJECT_UNLOCK(fs->first_object);
fs->first_m = NULL;
}
firstobjneedgiant = (fs->first_object->flags & OBJ_NEEDGIANT) != 0;
vm_object_deallocate(fs->first_object);
unlock_map(fs);
if (fs->vp != NULL) {
@ -174,7 +176,7 @@ unlock_and_deallocate(struct faultstate *fs)
fs->vp = NULL;
VFS_UNLOCK_GIANT(vfslocked);
}
if (fs->first_object->flags & OBJ_NEEDGIANT)
if (firstobjneedgiant)
VM_UNLOCK_GIANT();
}