d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not use OCP85XX_LBC_OFF twice when accessing LBC registers on MPC85XX.

Browse Source 
It turns LBC control registers were not programmed correctly on MPC85XX. We
were accessing bogus addresses as the base offset (OCP85XX_LBC_OFF) was
erroneously added during offset calculations.  Effectively the state of LBC
control registers was not altered by the kernel initialization code, but
everything worked as long as we coincided to use the same settings (LBC decode
windows) as firmware has initialized.

Submitted by:	Lukasz Wojcik
Reviewed by:	marcel
Approved by:	re (kensmith)
Obtained from:	Semihalf
This commit is contained in:
raj 2009-07-21 08:38:45 +00:00
parent f7cf3989b3
commit b89a897a7d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/powerpc/mpc85xx/lbc.h
View File

@ -39,10 +39,10 @@
#define LBC_DEVTYPE_RTC 2
/* Local access registers */
#define LBC85XX_BR(n) (OCP85XX_LBC_OFF + (8 * n))
#define LBC85XX_OR(n) (OCP85XX_LBC_OFF + 4 + (8 * n))
#define LBC85XX_LBCR (OCP85XX_LBC_OFF + 0xd0)
#define LBC85XX_LCRR (OCP85XX_LBC_OFF + 0xd4)
#define LBC85XX_BR(n) (8 * n)
#define LBC85XX_OR(n) (4 + (8 * n))
#define LBC85XX_LBCR (0xd0)
#define LBC85XX_LCRR (0xd4)
/* LBC machine select */
#define LBCRES_MSEL_GPCM 0