d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pf tests: Test PR 229241

Browse Source 
pfctl has an issue with 'set skip on <group>', which causes inconsistent
behaviour: the set skip directive works initially, but does not take
effect when the same rules are re-applied.

PR:		229241
MFC after:	1 week
This commit is contained in:
Kristof Provost 2019-01-13 05:31:53 +00:00
parent b1f3ab0051
commit b9dee1ff02
2 changed files with 39 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
tests/sys/netpfil/pf/set_skip.sh
View File

@ -30,7 +30,38 @@ set_skip_group_cleanup()
pft_cleanup
}
atf_test_case "set_skip_group_lo" "cleanup"
set_skip_group_lo_head()
{
atf_set descr 'Basic set skip test, lo'
atf_set require.user root
}
set_skip_group_lo_body()
{
# See PR 229241
pft_init
pft_mkjail alcatraz
jexec alcatraz ifconfig lo0 127.0.0.1/8 up
jexec alcatraz pfctl -e
pft_set_rules alcatraz "set skip on lo" \
"block on lo0"
atf_check -s exit:0 -o ignore jexec alcatraz ping -c 1 127.0.0.1
pft_set_rules noflush alcatraz "set skip on lo" \
"block on lo0"
atf_check -s exit:0 -o ignore jexec alcatraz ping -c 1 127.0.0.1
jexec alcatraz pfctl -s rules
}
set_skip_group_lo_cleanup()
{
pft_cleanup
}
atf_init_test_cases()
{
atf_add_test_case "set_skip_group"
atf_add_test_case "set_skip_group_lo"
}

10
tests/sys/netpfil/pf/utils.subr
View File

@ -49,8 +49,14 @@ pft_set_rules()
jname=$1
shift
# Flush all states, rules, fragments, ...
jexec ${jname} pfctl -F all
if [ $jname == "noflush" ];
then
jname=$1
shift
else
# Flush all states, rules, fragments, ...
jexec ${jname} pfctl -F all
fi
while [ $# -gt 0 ]; do
printf "$1\n"