d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Create a deterministic file in the kyua sandbox, instead of a

Browse Source 
temporary file outside the kyua sandbox

This helps ensure that the file is removed at test exit, and as
a side effect, cures a warning about umasks with Coverity.

MFC after:	3 days
Sponsored by:	Dell EMC Isilon
This commit is contained in:
ngie 2017-05-28 08:52:12 +00:00
parent 8ab86e050d
commit ba6949f2bf
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/sys/file/ftruncate_test.c
View File

@ -60,14 +60,14 @@ int
main(void) main(void)
{ {
int error, fd, fds[2], i, read_only_fd; int error, fd, fds[2], i, read_only_fd;
char path[PATH_MAX]; char path[] = "ftruncate_file";
struct stat sb; struct stat sb;
ssize_t size; ssize_t size;
off_t len; off_t len;
char ch; char ch;
/* /*
* Tests using a writable temporary file: grow and then shrink a file * Tests using a writable file: grow and then shrink a file
* using ftruncate and various lengths. Make sure that a negative * using ftruncate and various lengths. Make sure that a negative
* file length is rejected. Make sure that when we grow the file, * file length is rejected. Make sure that when we grow the file,
* bytes now in the range of the file size return 0. * bytes now in the range of the file size return 0.
@ -75,10 +75,9 @@ main(void)
* Save a read-only reference to the file to use later for read-only * Save a read-only reference to the file to use later for read-only
* descriptor tests. * descriptor tests.
*/ */
snprintf(path, PATH_MAX, "/tmp/ftruncate.XXXXXXXXXXXXX"); fd = open(path, O_RDWR|O_CREAT);
fd = mkstemp(path);
if (fd < 0) if (fd < 0)
err(1, "mkstemp"); err(1, "open(%s, O_RDWR|O_CREAT", path);
read_only_fd = open(path, O_RDONLY); read_only_fd = open(path, O_RDONLY);
if (read_only_fd < 0) { if (read_only_fd < 0) {
error = errno; error = errno;