Switch 586/686 back to generic_bzero and #if 0'd the "optimized" code. It

turns out that it actually reduces performance in real-world cases.

Noticed by:	bde
This commit is contained in:
David Greenman 1996-04-06 01:06:06 +00:00
parent bf152145d2
commit baddaf9480
5 changed files with 11 additions and 9 deletions

View File

@ -35,7 +35,7 @@
* SUCH DAMAGE.
*
* from: @(#)machdep.c 7.4 (Berkeley) 6/3/91
* $Id: machdep.c,v 1.179 1996/03/26 19:57:51 wollman Exp $
* $Id: machdep.c,v 1.180 1996/04/05 03:36:02 ache Exp $
*/
#include "npx.h"
@ -578,7 +578,6 @@ identifycpu()
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) / 100,
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) % 100);
printf("586");
bzero = i586_bzero;
break;
#endif
#if defined(I686_CPU)
@ -587,7 +586,6 @@ identifycpu()
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) / 100,
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) % 100);
printf("686");
bzero = i686_bzero;
break;
#endif
default:

View File

@ -30,7 +30,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: support.s,v 1.31 1995/12/28 23:14:40 davidg Exp $
* $Id: support.s,v 1.32 1996/03/31 04:05:03 bde Exp $
*/
#include "assym.s" /* system definitions */
@ -169,6 +169,7 @@ do0:
ret
#endif
#if 0 /* Actually lowers performance in real-world cases */
#if defined(I586_CPU) || defined(I686_CPU)
ALTENTRY(i586_bzero)
ENTRY(i686_bzero)
@ -227,6 +228,7 @@ ENTRY(i686_bzero)
popl %edi
ret
#endif
#endif
/* fillw(pat, base, cnt) */
ENTRY(fillw)

View File

@ -30,7 +30,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: support.s,v 1.31 1995/12/28 23:14:40 davidg Exp $
* $Id: support.s,v 1.32 1996/03/31 04:05:03 bde Exp $
*/
#include "assym.s" /* system definitions */
@ -169,6 +169,7 @@ do0:
ret
#endif
#if 0 /* Actually lowers performance in real-world cases */
#if defined(I586_CPU) || defined(I686_CPU)
ALTENTRY(i586_bzero)
ENTRY(i686_bzero)
@ -227,6 +228,7 @@ ENTRY(i686_bzero)
popl %edi
ret
#endif
#endif
/* fillw(pat, base, cnt) */
ENTRY(fillw)

View File

@ -35,7 +35,7 @@
* SUCH DAMAGE.
*
* from: @(#)machdep.c 7.4 (Berkeley) 6/3/91
* $Id: machdep.c,v 1.179 1996/03/26 19:57:51 wollman Exp $
* $Id: machdep.c,v 1.180 1996/04/05 03:36:02 ache Exp $
*/
#include "npx.h"
@ -578,7 +578,6 @@ identifycpu()
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) / 100,
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) % 100);
printf("586");
bzero = i586_bzero;
break;
#endif
#if defined(I686_CPU)
@ -587,7 +586,6 @@ identifycpu()
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) / 100,
((100 * i586_ctr_rate) >> I586_CTR_RATE_SHIFT) % 100);
printf("686");
bzero = i686_bzero;
break;
#endif
default:

View File

@ -30,7 +30,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: support.s,v 1.31 1995/12/28 23:14:40 davidg Exp $
* $Id: support.s,v 1.32 1996/03/31 04:05:03 bde Exp $
*/
#include "assym.s" /* system definitions */
@ -169,6 +169,7 @@ do0:
ret
#endif
#if 0 /* Actually lowers performance in real-world cases */
#if defined(I586_CPU) || defined(I686_CPU)
ALTENTRY(i586_bzero)
ENTRY(i686_bzero)
@ -227,6 +228,7 @@ ENTRY(i686_bzero)
popl %edi
ret
#endif
#endif
/* fillw(pat, base, cnt) */
ENTRY(fillw)