d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PR 206224] bv_cnt is sometimes examined without holding the bufobj lock

Browse Source 
Add locking around access to bv_cnt which is currently being done unlocked

PR:		206224
Reviewed by:	imp
Approved by:	jhb
MFC after:	1 week
Sponsored by:	Panasas, Inc.
Differential Revision:	https://reviews.freebsd.org/D4931
This commit is contained in:
Ravi Pokala 2016-01-17 01:04:20 +00:00
parent 66817b4bbc
commit bc089e5d7d
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/fs/nandfs/nandfs_segment.c
View File

@ -479,6 +479,7 @@ nandfs_iterate_dirty_vnodes(struct mount *mp, struct nandfs_seginfo *seginfo)
struct nandfs_node *nandfs_node;
struct vnode *vp, *mvp;
struct thread *td;
struct bufobj *bo;
int error, update;
td = curthread;
@ -499,17 +500,21 @@ nandfs_iterate_dirty_vnodes(struct mount *mp, struct nandfs_seginfo *seginfo)
update = 1;
}
bo = &vp->v_bufobj;
BO_LOCK(bo);
if (vp->v_bufobj.bo_dirty.bv_cnt) {
error = nandfs_iterate_dirty_buf(vp, seginfo, 0);
if (error) {
nandfs_error("%s: cannot iterate vnode:%p "
"err:%d\n", __func__, vp, error);
vput(vp);
BO_UNLOCK(bo);
return (error);
}
update = 1;
} else
vput(vp);
BO_UNLOCK(bo);
if (update)
nandfs_node_update(nandfs_node);