From bcfba66af4aa212825db2fc63258f430609eb928 Mon Sep 17 00:00:00 2001 From: mckusick Date: Wed, 22 May 2013 00:40:26 +0000 Subject: [PATCH] Null a pointer after it is freed so that when it is returned the return value is NULL. Based on the returned flags, the return value should never be inspected in the case where NULL is returned, but it is good coding practice not to return a pointer to freed memory. Found by: Coverity Scan, CID 1006096 Reviewed by: kib MFC after: 2 weeks --- sys/ufs/ffs/ffs_softdep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index af4f7c4e8824..788b75526f20 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -8150,6 +8150,7 @@ setup_newdir(dap, newinum, dinum, newdirbp, mkdirp) (inodedep->id_state & ALLCOMPLETE) == ALLCOMPLETE) { dap->da_state &= ~MKDIR_PARENT; WORKITEM_FREE(mkdir2, D_MKDIR); + mkdir2 = NULL; } else { LIST_INSERT_HEAD(&mkdirlisthd, mkdir2, md_mkdirs); WORKLIST_INSERT(&inodedep->id_bufwait, &mkdir2->md_list);