d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ping: fix -Wformat-truncating warning with GCC

Browse Source 
Increase buffer size for the string representation of n_time

ICMP timestamp is a 32-bit number. In pr_ntime(), number of minutes
and seconds is always 2 characters wide. Max. number of hours is 4
characters wide. The buffer size should be at least:

4 + 2 + 2 + 1 (':') + 1 (':') + 1 ('\0') = 11

Submitted by:	Ján Sučan <sucanjan@gmail.com>
MFC after:	2 weeks
Sponsored by:	Google, inc. (Google Summer of Code 2019)
Differential Revision:	https://reviews.freebsd.org/D21325
This commit is contained in:
asomers 2019-08-19 17:28:12 +00:00
parent edecb5a3c5
commit bd1a23c8ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sbin/ping/ping.c
View File

@ -1661,7 +1661,7 @@ pr_retip(struct ip *ip)
static char *
pr_ntime(n_time timestamp)
{
static char buf[10];
static char buf[11];
int hour, min, sec;
sec = ntohl(timestamp) / 1000;