d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sfxge(4): be ready to receive events immediately after event queues are created

Browse Source 
Submitted by:   Mark Spender <mspender at solarflare.com>
Reviewed by:    gnn
Sponsored by:   Solarflare Communications, Inc.
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D6507
This commit is contained in:
Andrew Rybchenko 2016-05-24 12:14:19 +00:00
parent 974692e3bf
commit bdb482bfa0
2 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/dev/sfxge/common/ef10_ev.c
View File

@ -275,6 +275,11 @@ ef10_ev_qcreate(
/* Set up the event queue */
irq = index; /* INIT_EVQ expects function-relative vector number */
/*
* Interrupts may be raised for events immediately after the queue is
* created. See bug58606.
*/
if ((rc = efx_mcdi_init_evq(enp, index, esmp, n, irq)) != 0)
goto fail3;

17
sys/dev/sfxge/common/efx_ev.c
View File

@ -251,16 +251,27 @@ efx_ev_qcreate(
eep->ee_mask = n - 1;
eep->ee_esmp = esmp;
if ((rc = eevop->eevo_qcreate(enp, index, esmp, n, id, eep)) != 0)
goto fail2;
/*
* Set outputs before the queue is created because interrupts may be
* raised for events immediately after the queue is created, before the
* function call below returns. See bug58606.
*
* The eepp pointer passed in by the client must therefore point to data
* shared with the client's event processing context.
*/
enp->en_ev_qcount++;
*eepp = eep;
if ((rc = eevop->eevo_qcreate(enp, index, esmp, n, id, eep)) != 0)
goto fail2;
return (0);
fail2:
EFSYS_PROBE(fail2);
*eepp = NULL;
enp->en_ev_qcount--;
EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_evq_t), eep);
fail1:
EFSYS_PROBE1(fail1, efx_rc_t, rc);