d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

smp_rendezvous() works for UP case as well, reduce duplicated

Browse Source 
code.  Also fix cast and remove unneeded XXX in comment.

Noted and reviewed by: jhb
Sponsored by:	The FreeBSD Foundation
MFC after:	2 weeks
Differential revision:	https://reviews.freebsd.org/D9657
This commit is contained in:
Konstantin Belousov 2017-02-17 22:49:52 +00:00
parent 936a2c763e
commit befb38bf9a
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/x86/x86/x86_mem.c
View File

@ -303,19 +303,13 @@ x86_mrt2mtrr(int flags, int oldval)
* Update running CPU(s) MTRRs to match the ranges in the descriptor
* list.
*
* XXX Must be called with interrupts enabled.
* Must be called with interrupts enabled.
*/
static void
x86_mrstore(struct mem_range_softc *sc)
{
#ifdef SMP
smp_rendezvous(NULL, x86_mrstoreone, NULL, sc);
#else
disable_intr(); /* disable interrupts */
x86_mrstoreone(sc);
enable_intr();
#endif
}
/*
@ -710,19 +704,13 @@ x86_mrAPinit(struct mem_range_softc *sc)
* Re-initialise running CPU(s) MTRRs to match the ranges in the descriptor
* list.
*
* XXX Must be called with interrupts enabled.
* Must be called with interrupts enabled.
*/
static void
x86_mrreinit(struct mem_range_softc *sc)
{
#ifdef SMP
smp_rendezvous(NULL, (void *)x86_mrAPinit, NULL, sc);
#else
disable_intr(); /* disable interrupts */
x86_mrAPinit(sc);
enable_intr();
#endif
smp_rendezvous(NULL, (void (*)(void *))x86_mrAPinit, NULL, sc);
}
static void