d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

newsyslog(8): Reject configurations that specify setuid or executable logs

Browse Source 
Prevent some classes of foot-shooting that may result in permissions
problems.

Reviewed by:	dab, delphij, vangyzen (earlier version)
Relnotes:	yes (behavior change)
Sponsored by:	Dell EMC Isilon
Differential Revision:	D16831
This commit is contained in:
Conrad Meyer 2018-08-21 23:12:46 +00:00
parent 1465a1e1eb
commit c657f9385b
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/newsyslog/newsyslog.c
View File

@ -1193,6 +1193,12 @@ parse_file(FILE *cf, struct cflist *work_p, struct cflist *glob_p,
if (!sscanf(q, "%o", &working->permissions))
errx(1, "error in config file; bad permissions:\n%s",
errline);
if ((working->permissions & ~DEFFILEMODE) != 0) {
warnx("File mode bits 0%o changed to 0%o in line:\n%s",
working->permissions,
working->permissions & DEFFILEMODE, errline);
working->permissions &= DEFFILEMODE;
}
q = parse = missing_field(sob(parse + 1), errline);
parse = son(parse);

7
usr.sbin/newsyslog/newsyslog.conf.5
View File

@ -21,7 +21,7 @@
.\" the suitability of this software for any purpose. It is
.\" provided "as is" without express or implied warranty.
.\"
.Dd January 15, 2018
.Dd August 21, 2018
.Dt NEWSYSLOG.CONF 5
.Os
.Sh NAME
@ -96,6 +96,11 @@ or
.Pa /etc/group .
.It Ar mode
Specify the file mode of the log file and archives.
Valid mode bits are
.Dv 0666 .
(That is, read and write permissions for the rotated log may be specified for
the owner, group, and others.)
All other mode bits are ignored.
.It Ar count
Specify the maximum number of archive files which may exist.
This does not consider the current log file.