d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libc/net: Fix some issues in inet6_opt_init() (from RFC 3542):

Browse Source 
* The RFC says (in section 10.1) that only when extbuf is not NULL,
extlen shall be checked, so don't perform this check when NULL is
passed.

* socklen_t is unsigned, so checking extlen for less than zero is
not needed.

Submitted by:	swildner@dragonflybsd.org
Reviewed by:	Mark Martinec <Mark.Martinec+freebsd@ijs.si>
Reviewed by:	hrs
Obtained by:	DragonFlyBSD
This commit is contained in:
Eitan Adler 2014-02-04 03:01:33 +00:00
parent 953c2c47eb
commit c6c4136a0a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/libc/net/ip6opt.c
View File

@ -381,11 +381,8 @@ inet6_opt_init(void *extbuf, socklen_t extlen)
{
struct ip6_ext *ext = (struct ip6_ext *)extbuf;
if (extlen < 0 || (extlen % 8))
return(-1);
if (ext) {
if (extlen == 0)
if (extlen == 0 || (extlen % 8))
return(-1);
ext->ip6e_len = (extlen >> 3) - 1;
}