d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c

Browse Source 
A pointer is first tested for NULL. If non-NULL, another pointer is
set equal to the first. The second pointer is then checked for NULL
and an error path taken if so. This second test and the associated
path is dead code as the pointer value, having just been checked for
NULL, cannot be NULL at this point. Remove the dead code.

Reported by:	Coverity
Reviewed by:	daniel.william.ryan_gmail.com, vangyzen
Sponsored by:	Dell EMC Isilon
Differential Revision:	https://reviews.freebsd.org/D19165
This commit is contained in:
dab 2019-02-22 18:43:27 +00:00
parent 5a174e4632
commit c782cfe37d
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c
View File

@ -1820,12 +1820,6 @@ tiNumOfLunIOCTLreq(
break;
}
tdIORequestBody = (tdIORequestBody_t *)tiRequestBody;
if(tdIORequestBody == agNULL)
{
status = IOCTL_CALL_FAIL;
break;
}
tdIORequestBody->tiIORequest = tiIORequest;
/* save context if we need to abort later */