d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply the same error checks to PAM_TTY in pam_sm_close_session() as in

Browse Source 
pam_sm_open_session(), avoiding false negatives when no tty is present.

Submitted by:	Todd C. Miller <millert@courtesan.com>
Approved by:	re (rwatson)
MFC after:	2 weeks
This commit is contained in:
des 2007-07-22 15:17:29 +00:00
parent 54314403b7
commit c81c3fef7a
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/libpam/modules/pam_lastlog/pam_lastlog.c
View File

@ -178,8 +178,11 @@ pam_sm_close_session(pam_handle_t *pamh __unused, int flags __unused,
int argc __unused, const char *argv[] __unused)
{
const void *tty;
int pam_err;
pam_get_item(pamh, PAM_TTY, (const void **)&tty);
pam_err = pam_get_item(pamh, PAM_TTY, (const void **)&tty);
if (pam_err != PAM_SUCCESS)
goto err;
if (strncmp(tty, _PATH_DEV, strlen(_PATH_DEV)) == 0)
tty = (const char *)tty + strlen(_PATH_DEV);
if (*(const char *)tty == '\0')
@ -189,6 +192,11 @@ pam_sm_close_session(pam_handle_t *pamh __unused, int flags __unused,
__func__, (const char *)tty);
logwtmp(tty, "", "");
return (PAM_SUCCESS);
err:
if (openpam_get_option(pamh, "no_fail"))
return (PAM_SUCCESS);
return (pam_err);
}
PAM_MODULE_ENTRY("pam_lastlog");