d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFC: Detect the snapshot file being prematurely unlinked.

Browse Source
This commit is contained in:
tegge 2006-05-14 00:02:48 +00:00
parent 24528b3490
commit c83e05380e
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/ufs/ffs/ffs_snapshot.c
View File

@ -405,6 +405,11 @@ ffs_snapshot(mp, snapfile)
vn_start_write(NULL, &wrtmp, V_WAIT);
}
vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, td);
if (ip->i_effnlink == 0) {
error = ENOENT; /* Snapshot file unlinked */
sn = NULL;
goto out1;
}
if (collectsnapstats)
nanotime(&starttime);
/*
@ -763,12 +768,17 @@ ffs_snapshot(mp, snapfile)
* the inode for this snapshot then a deadlock can occur. Drop
* the snapshot lock until the buffer has been written.
*/
VREF(vp); /* Protect against ffs_snapgone() */
VOP_UNLOCK(vp, 0, td);
(void) bread(ip->i_devvp,
fsbtodb(fs, ino_to_fsba(fs, ip->i_number)),
(int) fs->fs_bsize, NOCRED, &nbp);
brelse(nbp);
vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, td);
if (ip->i_effnlink == 0)
error = ENOENT; /* Snapshot file unlinked */
else
vrele(vp); /* Drop extra reference */
done:
FREE(copy_fs->fs_csp, M_UFSMNT);
bawrite(sbp);