d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Expose argument names for non static ENA driver functions

Browse Source 
As functions which are declared in the header files are intended to be
the interface and are going to be used by other files, it's better to
include argument names in the definition, so the caller won't have to
check the .c file in order to check their meaning and order.

Submitted by:  Michal Krawczyk <mk@semihalf.com>
Obtained from: Semihalf
Sponsored by:  Amazon, Inc.
This commit is contained in:
mw 2020-05-26 15:41:53 +00:00
parent 34de12cbd9
commit c998521ae3
4 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/dev/ena/ena.h
View File

@ -483,11 +483,11 @@ static inline int ena_mbuf_count(struct mbuf *mbuf)
return count;
}
int ena_up(struct ena_adapter *);
void ena_down(struct ena_adapter *);
int ena_restore_device(struct ena_adapter *);
void ena_destroy_device(struct ena_adapter *, bool);
int ena_refill_rx_bufs(struct ena_ring *, uint32_t);
int ena_up(struct ena_adapter *adapter);
void ena_down(struct ena_adapter *adapter);
int ena_restore_device(struct ena_adapter *adapter);
void ena_destroy_device(struct ena_adapter *adapter, bool graceful);
int ena_refill_rx_bufs(struct ena_ring *rx_ring, uint32_t num);
static inline void
ena_trigger_reset(struct ena_adapter *adapter,

8
sys/dev/ena/ena_datapath.h
View File

@ -34,9 +34,9 @@
#ifndef ENA_TXRX_H
#define ENA_TXRX_H
void ena_cleanup(void *, int);
void ena_qflush(if_t);
int ena_mq_start(if_t, struct mbuf *);
void ena_deferred_mq_start(void *, int);
void ena_cleanup(void *arg, int pending);
void ena_qflush(if_t ifp);
int ena_mq_start(if_t ifp, struct mbuf *m);
void ena_deferred_mq_start(void *arg, int pending);
#endif /* ENA_TXRX_H */

20
sys/dev/ena/ena_netmap.h
View File

@ -46,15 +46,15 @@
#include <sys/selinfo.h>
#include <dev/netmap/netmap_kern.h>
int ena_netmap_attach(struct ena_adapter *);
int ena_netmap_alloc_rx_slot(struct ena_adapter *, struct ena_ring *,
struct ena_rx_buffer *);
void ena_netmap_free_rx_slot(struct ena_adapter *, struct ena_ring *,
struct ena_rx_buffer *);
bool ena_rx_ring_in_netmap(struct ena_adapter *, int);
bool ena_tx_ring_in_netmap(struct ena_adapter *, int);
void ena_netmap_reset_rx_ring(struct ena_adapter *, int);
void ena_netmap_reset_tx_ring(struct ena_adapter *, int);
void ena_netmap_unload(struct ena_adapter *, bus_dmamap_t);
int ena_netmap_attach(struct ena_adapter *adapter);
int ena_netmap_alloc_rx_slot(struct ena_adapter *adapter,
struct ena_ring *rx_ring, struct ena_rx_buffer *rx_info);
void ena_netmap_free_rx_slot(struct ena_adapter *adapter,
struct ena_ring *rx_ring, struct ena_rx_buffer *rx_info);
bool ena_rx_ring_in_netmap(struct ena_adapter *adapter, int qid);
bool ena_tx_ring_in_netmap(struct ena_adapter *adapter, int qid);
void ena_netmap_reset_rx_ring(struct ena_adapter *adapter, int qid);
void ena_netmap_reset_tx_ring(struct ena_adapter *adapter, int qid);
void ena_netmap_unload(struct ena_adapter *adapter, bus_dmamap_t map);
#endif /* _ENA_NETMAP_H_ */

2
sys/dev/ena/ena_sysctl.h
View File

@ -39,7 +39,7 @@
#include "ena.h"
void ena_sysctl_add_nodes(struct ena_adapter *);
void ena_sysctl_add_nodes(struct ena_adapter *adapter);
extern int ena_enable_9k_mbufs;
#define ena_mbuf_sz (ena_enable_9k_mbufs ? MJUM9BYTES : MJUMPAGESIZE)