d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not hold locks around hardware context reads.

Browse Source 
MFC after:	3 days
This commit is contained in:
np 2013-02-09 00:35:28 +00:00
parent d169cde81c
commit ca3fe89a4e
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sys/dev/cxgbe/t4_main.c
View File

@ -5161,23 +5161,24 @@ get_sge_context(struct adapter *sc, struct t4_sge_context *cntxt)
cntxt->mem_id != CTXT_FLM && cntxt->mem_id != CTXT_CNM)
return (EINVAL);
rc = begin_synchronized_op(sc, NULL, SLEEP_OK | INTR_OK, "t4ctxt");
if (rc)
return (rc);
if (sc->flags & FW_OK) {
rc = begin_synchronized_op(sc, NULL, HOLD_LOCK, "t4ctxt");
if (rc == 0) {
rc = -t4_sge_ctxt_rd(sc, sc->mbox, cntxt->cid,
cntxt->mem_id, &cntxt->data[0]);
end_synchronized_op(sc, LOCK_HELD);
if (rc == 0)
return (0);
}
rc = -t4_sge_ctxt_rd(sc, sc->mbox, cntxt->cid, cntxt->mem_id,
&cntxt->data[0]);
if (rc == 0)
goto done;
}
/*
* Read via firmware failed or wasn't even attempted. Read directly via
* the backdoor.
*/
rc = -t4_sge_ctxt_rd_bd(sc, cntxt->cid, cntxt->mem_id,
&cntxt->data[0]);
rc = -t4_sge_ctxt_rd_bd(sc, cntxt->cid, cntxt->mem_id, &cntxt->data[0]);
done:
end_synchronized_op(sc, 0);
return (rc);
}