d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Turn off BUILD_WITH_STRICT_TMPPATH by default

Browse Source 
Building with a strict $PATH (without inheriting from the parent
environment) still causes build failures in some workflows/environemnts
that I have not yet tested.
I will try to bring this back once these issues have all been resolved
since it is actually extremely useful in tracking broken dependencies
and wrong assumptions about the build environemt.

Discussed With:	brooks
This commit is contained in:
Alex Richardson 2018-11-06 18:06:52 +00:00
parent 4a1f3ed354
commit cd6b0f0ea5
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Makefile.inc1
View File

@ -589,12 +589,11 @@ STRICTTMPPATH= ${XPATH}:${BPATH}:${UNIVERSE_TOOLCHAIN_PATH}
# the build to break on other systems that don't have that tool. For now we # the build to break on other systems that don't have that tool. For now we
# still allow using the old behaviour (inheriting $PATH) if # still allow using the old behaviour (inheriting $PATH) if
# BUILD_WITH_STRICT_TMPPATH is set to 0 but this will eventually be removed. # BUILD_WITH_STRICT_TMPPATH is set to 0 but this will eventually be removed.
.if ${USING_SYSTEM_LINKER} != "no" || ${USING_SYSTEM_COMPILER} != "no"
# strict $PATH does not work yet with USING_SYSTEM_LINKER/USING_SYSTEM_COMPILER # Currently strict $PATH can cause build failures and does not work yet with
# USING_SYSTEM_LINKER/USING_SYSTEM_COMPILER. Once these issues have been
# resolved it will be turned on by default.
BUILD_WITH_STRICT_TMPPATH?=0 BUILD_WITH_STRICT_TMPPATH?=0
.else
BUILD_WITH_STRICT_TMPPATH?=1
.endif
.if ${BUILD_WITH_STRICT_TMPPATH} != 0 .if ${BUILD_WITH_STRICT_TMPPATH} != 0
TMPPATH= ${STRICTTMPPATH} TMPPATH= ${STRICTTMPPATH}
.else .else