d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lldb: workaround to permit cross-arch core file debugging

Browse Source 
FreeBSD core files have no section table and thus LLDB's OS and vendor
detection logic does not work. If we encounter such an ELF file, update
an unknown OS to match the host.

This is not really the correct way to handle this, but more extensive
rework of ObjectFileELF will be needed and this change restores cross-
arch core debugging until that can be completed.
This commit is contained in:
emaste 2015-02-17 18:33:17 +00:00
parent 458f969535
commit cee0ede2f2
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/llvm/tools/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
View File

@ -1331,8 +1331,11 @@ ObjectFileELF::GetSectionHeaderInfo(SectionHeaderColl &section_headers,
}
// If there are no section headers we are done.
if (header.e_shnum == 0)
if (header.e_shnum == 0) {
if (arch_spec.GetTriple().getOS() == llvm::Triple::OSType::UnknownOS)
arch_spec.GetTriple().setOSName(HostInfo::GetOSString().data());
return 0;
}
Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_MODULES));