d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Hold the global IPX PCB list mutex in the IPX input path when walking

Browse Source 
the IPX PCB list.

MFC after:	3 weeks
This commit is contained in:
rwatson 2005-01-09 05:06:19 +00:00
parent a6ab698ab0
commit cfbc0538b8
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/netipx/ipx_input.c
View File

@ -162,11 +162,13 @@ ipxintr(struct mbuf *m)
/* /*
* Give any raw listeners a crack at the packet * Give any raw listeners a crack at the packet
*/ */
IPX_LIST_LOCK();
LIST_FOREACH(ipxp, &ipxrawpcb_list, ipxp_list) { LIST_FOREACH(ipxp, &ipxrawpcb_list, ipxp_list) {
struct mbuf *m1 = m_copy(m, 0, (int)M_COPYALL); struct mbuf *m1 = m_copy(m, 0, (int)M_COPYALL);
if (m1 != NULL) if (m1 != NULL)
ipx_input(m1, ipxp); ipx_input(m1, ipxp);
} }
IPX_LIST_UNLOCK();
ipx = mtod(m, struct ipx *); ipx = mtod(m, struct ipx *);
len = ntohs(ipx->ipx_len); len = ntohs(ipx->ipx_len);
@ -262,6 +264,7 @@ ipxintr(struct mbuf *m)
/* /*
* Locate pcb for datagram. * Locate pcb for datagram.
*/ */
IPX_LIST_LOCK();
ipxp = ipx_pcblookup(&ipx->ipx_sna, ipx->ipx_dna.x_port, IPX_WILDCARD); ipxp = ipx_pcblookup(&ipx->ipx_sna, ipx->ipx_dna.x_port, IPX_WILDCARD);
/* /*
* Switch out to protocol's input routine. * Switch out to protocol's input routine.
@ -272,11 +275,13 @@ ipxintr(struct mbuf *m)
switch (ipx->ipx_pt) { switch (ipx->ipx_pt) {
case IPXPROTO_SPX: case IPXPROTO_SPX:
spx_input(m, ipxp); spx_input(m, ipxp);
IPX_LIST_UNLOCK();
return; return;
} }
ipx_input(m, ipxp); ipx_input(m, ipxp);
} else } else
m_freem(m); m_freem(m);
IPX_LIST_UNLOCK();
} }
void void
@ -474,6 +479,7 @@ struct ifnet *ifp;
/* /*
* Give any raw listeners a crack at the packet * Give any raw listeners a crack at the packet
*/ */
IPX_LIST_LOCK();
LIST_FOREACH(ipxp, &ipxrawpcb_list, ipxp_list) { LIST_FOREACH(ipxp, &ipxrawpcb_list, ipxp_list) {
struct mbuf *m0 = m_copy(m, 0, (int)M_COPYALL); struct mbuf *m0 = m_copy(m, 0, (int)M_COPYALL);
if (m0 != NULL) { if (m0 != NULL) {
@ -504,4 +510,5 @@ struct ifnet *ifp;
ipx_input(m0, ipxp); ipx_input(m0, ipxp);
} }
} }
IPX_LIST_UNLOCK();
} }