d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Plug a leak in the newer contigmalloc() implementation. Specifically, if

Browse Source 
a multipage allocation was aborted midway, the pages that were already
allocated were not always returned to the free list.

Submitted by: tegge
This commit is contained in:
Alan Cox 2006-01-26 05:51:26 +00:00
parent aed1a1f179
commit cfc26cd69c
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/vm/vm_contig.c
View File

@ -473,19 +473,14 @@ cleanup_freed:
}
}
if (pqtype == PQ_CACHE) {
if (m->hold_count != 0) {
start = i - npages + 1;
goto retry;
}
if (m->hold_count != 0)
goto cleanup_freed;
object = m->object;
if (!VM_OBJECT_TRYLOCK(object)) {
start = i - npages + 1;
goto retry;
}
if (!VM_OBJECT_TRYLOCK(object))
goto cleanup_freed;
if ((m->flags & PG_BUSY) || m->busy != 0) {
VM_OBJECT_UNLOCK(object);
start = i - npages + 1;
goto retry;
goto cleanup_freed;
}
vm_page_free(m);
VM_OBJECT_UNLOCK(object);