From d03048e85374bd7f304f38a595afbfcf907c4ccc Mon Sep 17 00:00:00 2001 From: marcel Date: Mon, 2 Jul 2012 21:21:12 +0000 Subject: [PATCH] Fix a typo that resulted in or-ing PTE_UW twice whrn PTE_SW was needed. Note that setting the PTE_MODIFIED bit based on whether write is possible is incorrect. We should set PTE_MODIFIED based on whether the access is a write operation. --- sys/powerpc/booke/trap_subr.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/powerpc/booke/trap_subr.S b/sys/powerpc/booke/trap_subr.S index c3b856a6bc99..33976ca159ec 100644 --- a/sys/powerpc/booke/trap_subr.S +++ b/sys/powerpc/booke/trap_subr.S @@ -668,7 +668,7 @@ tlb_fill_entry: lwarx %r21, %r23, %r25 /* get pte->flags */ oris %r21, %r21, PTE_REFERENCED@h /* set referenced bit */ - andi. %r22, %r21, (PTE_UW | PTE_UW)@l /* check if writable */ + andi. %r22, %r21, (PTE_SW | PTE_UW)@l /* check if writable */ beq 2f oris %r21, %r21, PTE_MODIFIED@h /* set modified bit */ 2: