d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

According to in_pcb.h protocol binding information has double locking.

Browse Source 
It allows access it while list travercing holding only global pcbinfo lock.
This commit is contained in:
Alexander Motin 2008-07-27 20:48:22 +00:00
parent b11e21ae80
commit d185578a78
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/netinet/ip_divert.c
View File

@ -268,9 +268,9 @@ divert_packet(struct mbuf *m, int incoming)
nport = htons((u_int16_t)divert_info(mtag));
INP_INFO_RLOCK(&divcbinfo);
LIST_FOREACH(inp, &divcb, inp_list) {
INP_RLOCK(inp);
/* XXX why does only one socket match? */
if (inp->inp_lport == nport) {
INP_RLOCK(inp);
sa = inp->inp_socket;
SOCKBUF_LOCK(&sa->so_rcv);
if (sbappendaddr_locked(&sa->so_rcv,
@ -283,7 +283,6 @@ divert_packet(struct mbuf *m, int incoming)
INP_RUNLOCK(inp);
break;
}
INP_RUNLOCK(inp);
}
INP_INFO_RUNLOCK(&divcbinfo);
if (sa == NULL) {