Use S_ISREG instead of manual & (also it's better to compare the

result from & and the pattern instead of just assuming it's one bit
value).

Pointed out by Tianjie Mao <tjmao tjmao com>.

MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D4827
This commit is contained in:
delphij 2017-01-19 08:01:35 +00:00
parent d5577aec9c
commit d1c2b08754

View File

@ -391,7 +391,7 @@ mf_fgets(SPACE *sp, enum e_spflag spflag)
if (inplace != NULL) {
if (lstat(fname, &sb) != 0)
err(1, "%s", fname);
if (!(sb.st_mode & S_IFREG))
if (!S_ISREG(sb.st_mode))
errx(1, "%s: %s %s", fname,
"in-place editing only",
"works for regular files");