d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unneeded mount point unlock function calls.

Browse Source 
The ext2_nodealloccg() function unlocks the mount point
in case of successful node allocation.
The additional unlocks are not required and should be removed.

PR:		236452
Reported by:	pho
MFC after:	3 days
This commit is contained in:
fsu 2019-03-15 11:49:46 +00:00
parent 84b9791bcc
commit d3433b6717
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/fs/ext2fs/ext2_alloc.c
View File

@ -412,23 +412,21 @@ ext2_valloc(struct vnode *pvp, int mode, struct ucred *cred, struct vnode **vpp)
td = curthread;
error = vfs_hash_get(ump->um_mountp, ino, LK_EXCLUSIVE, td, vpp, NULL, NULL);
if (error || *vpp != NULL) {
EXT2_UNLOCK(ump);
return (error);
}
ip = malloc(sizeof(struct inode), M_EXT2NODE, M_WAITOK | M_ZERO);
if (ip == NULL) {
EXT2_UNLOCK(ump);
return (ENOMEM);
}
/* Allocate a new vnode/inode. */
if ((error = getnewvnode("ext2fs", ump->um_mountp, &ext2_vnodeops, &vp)) != 0) {
free(ip, M_EXT2NODE);
EXT2_UNLOCK(ump);
return (error);
}
lockmgr(vp->v_vnlock, LK_EXCLUSIVE, NULL);
vp->v_data = ip;
ip->i_vnode = vp;
ip->i_e2fs = fs = ump->um_e2fs;
@ -438,11 +436,9 @@ ext2_valloc(struct vnode *pvp, int mode, struct ucred *cred, struct vnode **vpp)
ip->i_next_alloc_block = 0;
ip->i_next_alloc_goal = 0;
lockmgr(vp->v_vnlock, LK_EXCLUSIVE, NULL);
error = insmntque(vp, ump->um_mountp);
if (error) {
free(ip, M_EXT2NODE);
EXT2_UNLOCK(ump);
return (error);
}
@ -450,7 +446,6 @@ ext2_valloc(struct vnode *pvp, int mode, struct ucred *cred, struct vnode **vpp)
if (error || *vpp != NULL) {
*vpp = NULL;
free(ip, M_EXT2NODE);
EXT2_UNLOCK(ump);
return (error);
}
@ -458,7 +453,6 @@ ext2_valloc(struct vnode *pvp, int mode, struct ucred *cred, struct vnode **vpp)
vput(vp);
*vpp = NULL;
free(ip, M_EXT2NODE);
EXT2_UNLOCK(ump);
return (error);
}