d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pfctl: Do not allow whitespace in macro names

Browse Source 
i.e. "this is" = "a variable" is not valid. It was accepted by the
parser, but the variable could not be used afterwards.

Obtained from:	OpenBSD
This commit is contained in:
Kristof Provost 2018-10-28 05:41:13 +00:00
parent 71f8908a1a
commit d3f6532494
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sbin/pfctl/parse.y
View File

@ -758,8 +758,16 @@ numberstring : NUMBER {
;
varset : STRING '=' varstring {
char *s = $1;
if (pf->opts & PF_OPT_VERBOSE)
printf("%s = \"%s\"\n", $1, $3);
while (*s++) {
if (isspace((unsigned char)*s)) {
yyerror("macro name cannot contain "
"whitespace");
YYERROR;
}
}
if (symset($1, $3, 0) == -1)
err(1, "cannot store variable %s", $1);
free($1);