d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When querying a process's umask via sysctl in libprocstat(), don't

Browse Source 
print a warning if EPERM is returned as this is an expected failure
mode rather than error -- similar to current handling of ESRCH.
This makes the output of 'procstat -as' vastly more palatable.

MFC after:	3 days
Sponsored by:	DARPA, AFRL
This commit is contained in:
rwatson 2014-03-02 13:26:08 +00:00
parent 6c0aa10090
commit d533359f74
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libprocstat/libprocstat.c
View File

@ -2052,7 +2052,7 @@ procstat_getumask_sysctl(pid_t pid, unsigned short *maskp)
mib[3] = pid; mib[3] = pid;
len = sizeof(*maskp); len = sizeof(*maskp);
error = sysctl(mib, 4, maskp, &len, NULL, 0); error = sysctl(mib, 4, maskp, &len, NULL, 0);
if (error != 0 && errno != ESRCH) if (error != 0 && errno != ESRCH && errno != EPERM)
warn("sysctl: kern.proc.umask: %d", pid); warn("sysctl: kern.proc.umask: %d", pid);
return (error); return (error);
} }