d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the parse type for NGM_LISTTYPES.

Browse Source 
Actually, text versions of generic commands are not used, since ngctl(8)
uses binary messages for them. And to request a text command one needs
a working ngctl(8). That's why the bug was never discovered. I'm pondering
on removing the text support for generic commands.

Found by:	dim with clang 3.4
This commit is contained in:
glebius 2013-12-29 18:34:29 +00:00
parent 98b4df3a23
commit d5c26ca616
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netgraph/ng_base.c
View File

@ -473,7 +473,7 @@ static const struct ng_parse_type ng_generic_linkinfo_array_type = {
&ng_generic_linkinfo_array_type_info
};
DEFINE_PARSE_STRUCT_TYPE(typelist, TYPELIST, (&ng_generic_nodeinfoarray_type));
DEFINE_PARSE_STRUCT_TYPE(typelist, TYPELIST, (&ng_generic_typeinfoarray_type));
DEFINE_PARSE_STRUCT_TYPE(hooklist, HOOKLIST,
(&ng_generic_nodeinfo_type, &ng_generic_linkinfo_array_type));
DEFINE_PARSE_STRUCT_TYPE(listnodes, LISTNODES,
@ -549,7 +549,7 @@ static const struct ng_cmdlist ng_generic_cmds[] = {
NGM_LISTTYPES,
"listtypes",
NULL,
&ng_generic_typeinfo_type
&ng_generic_typelist_type
},
{
NGM_GENERIC_COOKIE,