d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

strdup() value of term to correctly preserve contents.

Browse Source 
Rearrange validation logic so that it works correctly when
compiled with kerberos support. Closes PR#3056.
This commit is contained in:
David Nugent 1997-03-24 21:22:12 +00:00
parent e71e7150fd
commit d8a7b3477f
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
usr.bin/login/login.c
View File

@ -482,19 +482,16 @@ main(argc, argv)
* If trying to log in as root without Kerberos,
* but with insecure terminal, refuse the login attempt.
*/
if (pwd && !rval) {
#if defined(KERBEROS) || defined(LOGIN_CAP_AUTH)
if (authok == 0)
if (authok == 0 && rootlogin && !rootok)
#else
if (rootlogin && !rootok)
#endif
if (pwd && !rval && rootlogin && !rootok) {
/* use same message as for authentication failure */
/* (void)fprintf(stderr, "%s login refused on this terminal.\n", pwd->pw_name); */
refused(NULL, "NOROOT", 0);
/* preserve backoff behaviour even for failed root */
/* continue; */
refused(NULL, "NOROOT", 0);
else /* valid password & authenticated */
break;
}
/* valid password & authenticated */
else if (pwd && !rval)
break;
(void)printf("Login incorrect\n");
failures++;
@ -651,7 +648,8 @@ main(argc, argv)
/*
* Preserve TERM if it happens to be already set.
*/
term = getenv("TERM");
if ((term = getenv("TERM")) != NULL)
term = strdup(term);
/*
* Exclude cons/vt/ptys only, assume dialup otherwise