Correct test in poll loop for determining that the mailbox is free to

accept a new command.
This commit is contained in:
Justin T. Gibbs 1999-01-28 03:30:02 +00:00
parent e3870274b4
commit dd3afbd452
2 changed files with 4 additions and 14 deletions

View File

@ -25,7 +25,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: ahb.c,v 1.4 1998/10/09 21:38:31 gibbs Exp $
* $Id: ahb.c,v 1.5 1999/01/28 01:33:02 dillon Exp $
*/
#include "eisa.h"
@ -171,14 +171,9 @@ ahbqueuembox(struct ahb_softc *ahb, u_int32_t mboxval, u_int attn_code)
while (--loopmax) {
u_int status;
/*
* XXX - this still looks wrong, even after fixing the
* parenthesization.
*/
status = ahb_inb(ahb, HOSTSTAT);
if ((status & (HOSTSTAT_MBOX_EMPTY|HOSTSTAT_BUSY))
!= HOSTSTAT_MBOX_EMPTY)
== HOSTSTAT_MBOX_EMPTY)
break;
DELAY(20);
}

View File

@ -25,7 +25,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: ahb.c,v 1.4 1998/10/09 21:38:31 gibbs Exp $
* $Id: ahb.c,v 1.5 1999/01/28 01:33:02 dillon Exp $
*/
#include "eisa.h"
@ -171,14 +171,9 @@ ahbqueuembox(struct ahb_softc *ahb, u_int32_t mboxval, u_int attn_code)
while (--loopmax) {
u_int status;
/*
* XXX - this still looks wrong, even after fixing the
* parenthesization.
*/
status = ahb_inb(ahb, HOSTSTAT);
if ((status & (HOSTSTAT_MBOX_EMPTY|HOSTSTAT_BUSY))
!= HOSTSTAT_MBOX_EMPTY)
== HOSTSTAT_MBOX_EMPTY)
break;
DELAY(20);
}