d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

o Check that -w width is not above maximum. Use DWIDTH instead of

Browse Source 
hardcoded constant.

Reported by:	Gruzicki Wlodek on BugTraq
Obtained from:	NetBSD, OpenBSD
MFC after:	1 week
This commit is contained in:
maxim 2006-11-22 21:05:17 +00:00
parent 74662be6c0
commit df4984d2dd
1 changed files with 2 additions and 2 deletions

4
usr.bin/banner/banner.c

@ -1045,7 +1045,7 @@ main(int argc, char *argv[])
break; break;
case 'w': case 'w':
width = atoi(optarg); width = atoi(optarg);
if (width <= 0) if (width <= 0 || width > DWIDTH)
errx(1, "illegal argument for -w option"); errx(1, "illegal argument for -w option");
break; break;
case '?': case '?':
@ -1056,7 +1056,7 @@ main(int argc, char *argv[])
argv += optind; argv += optind;
for (i = 0; i < width; i++) { for (i = 0; i < width; i++) {
j = i * 132 / width; j = i * DWIDTH / width;
print[j] = 1; print[j] = 1;
} }