d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check return value of seteuid() and bail out if we fail.

Browse Source 
MFC after:	2 weeks
This commit is contained in:
Xin LI 2017-06-19 07:02:52 +00:00
parent acd690d524
commit df9abd97ac
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
usr.sbin/rpc.lockd/lock_proc.c
View File

@ -276,7 +276,10 @@ get_client(struct sockaddr *host_addr, rpcvers_t vers)
/* Regain root privileges, for bindresvport. */
old_euid = geteuid();
seteuid(0);
if (seteuid(0) != 0) {
syslog(LOG_ERR, "seteuid(0) failed");
return NULL;
}
/*
* Bind the client FD to a reserved port.
@ -285,7 +288,10 @@ get_client(struct sockaddr *host_addr, rpcvers_t vers)
bindresvport(clnt_fd, NULL);
/* Drop root privileges again. */
seteuid(old_euid);
if (seteuid(old_euid) != 0) {
syslog(LOG_ERR, "seteuid(%d) failed", old_euid);
return NULL;
}
/* Success - update the cache entry */
clnt_cache_ptr[clnt_cache_next_to_use] = client;