d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unecessary and clearly wrong usage of atomic(9).

Browse Source 
Reported by:  avg
This commit is contained in:
Pyun YongHyeon 2010-12-14 17:39:10 +00:00
parent 1357b83499
commit e23559db8e
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/dev/ale/if_ale.c
View File

@ -66,7 +66,6 @@ __FBSDID("$FreeBSD$");
#include <dev/pci/pcireg.h> #include <dev/pci/pcireg.h>
#include <dev/pci/pcivar.h> #include <dev/pci/pcivar.h>
#include <machine/atomic.h>
#include <machine/bus.h> #include <machine/bus.h>
#include <machine/in_cksum.h> #include <machine/in_cksum.h>
@ -2284,8 +2283,7 @@ ale_int_task(void *arg, int pending)
sc = (struct ale_softc *)arg; sc = (struct ale_softc *)arg;
status = CSR_READ_4(sc, ALE_INTR_STATUS); status = CSR_READ_4(sc, ALE_INTR_STATUS);
more = atomic_readandclear_int(&sc->ale_morework); if (sc->ale_morework != 0)
if (more != 0)
status |= INTR_RX_PKT; status |= INTR_RX_PKT;
if ((status & ALE_INTRS) == 0) if ((status & ALE_INTRS) == 0)
goto done; goto done;
@ -2298,7 +2296,7 @@ ale_int_task(void *arg, int pending)
if ((ifp->if_drv_flags & IFF_DRV_RUNNING) != 0) { if ((ifp->if_drv_flags & IFF_DRV_RUNNING) != 0) {
more = ale_rxeof(sc, sc->ale_process_limit); more = ale_rxeof(sc, sc->ale_process_limit);
if (more == EAGAIN) if (more == EAGAIN)
atomic_set_int(&sc->ale_morework, 1); sc->ale_morework = 1;
else if (more == EIO) { else if (more == EIO) {
ALE_LOCK(sc); ALE_LOCK(sc);
sc->ale_stats.reset_brk_seq++; sc->ale_stats.reset_brk_seq++;
@ -3002,7 +3000,7 @@ ale_init_rx_pages(struct ale_softc *sc)
ALE_LOCK_ASSERT(sc); ALE_LOCK_ASSERT(sc);
atomic_set_int(&sc->ale_morework, 0); sc->ale_morework = 0;
sc->ale_cdata.ale_rx_seqno = 0; sc->ale_cdata.ale_rx_seqno = 0;
sc->ale_cdata.ale_rx_curp = 0; sc->ale_cdata.ale_rx_curp = 0;