From e3a0bc583b84d05e232308a86c721365baf65054 Mon Sep 17 00:00:00 2001 From: Alexander Motin Date: Mon, 23 Nov 2015 20:44:49 +0000 Subject: [PATCH] Remove "disable" hint, which duplicates system-wide "disabled". --- share/man/man4/isp.4 | 2 -- sys/dev/isp/isp_freebsd.h | 1 - sys/dev/isp/isp_pci.c | 20 -------------------- sys/dev/isp/isp_sbus.c | 13 ------------- 4 files changed, 36 deletions(-) diff --git a/share/man/man4/isp.4 b/share/man/man4/isp.4 index 7a39d927cc56..71050a294e89 100644 --- a/share/man/man4/isp.4 +++ b/share/man/man4/isp.4 @@ -124,8 +124,6 @@ The following options are switchable by setting values in .Pp They are: .Bl -tag -width indent -.It Va hint.isp.0.disable -A hint value to disable driver in kernel. .It Va hint.isp.0.fwload_disable A hint value to disable loading of firmware .Xr ispfw 4 . diff --git a/sys/dev/isp/isp_freebsd.h b/sys/dev/isp/isp_freebsd.h index 1a74024900aa..8712cec274e2 100644 --- a/sys/dev/isp/isp_freebsd.h +++ b/sys/dev/isp/isp_freebsd.h @@ -311,7 +311,6 @@ struct isposinfo { timer_active : 1, autoconf : 1, ehook_active : 1, - disabled : 1, mbox_sleeping : 1, mbox_sleep_ok : 1, mboxcmd_done : 1, diff --git a/sys/dev/isp/isp_pci.c b/sys/dev/isp/isp_pci.c index 1f3d6d697789..87fbb8df5537 100644 --- a/sys/dev/isp/isp_pci.c +++ b/sys/dev/isp/isp_pci.c @@ -456,16 +456,6 @@ isp_get_generic_options(device_t dev, ispsoftc_t *isp) { int tval; - /* - * Figure out if we're supposed to skip this one. - */ - tval = 0; - if (resource_int_value(device_get_name(dev), device_get_unit(dev), "disable", &tval) == 0 && tval) { - device_printf(dev, "disabled at user request\n"); - isp->isp_osinfo.disabled = 1; - return; - } - tval = 0; if (resource_int_value(device_get_name(dev), device_get_unit(dev), "fwload_disable", &tval) == 0 && tval != 0) { isp->isp_confopts |= ISP_CFG_NORELOAD; @@ -709,16 +699,6 @@ isp_pci_attach(device_t dev) isp_nvports = 0; isp_get_generic_options(dev, isp); - /* - * Check to see if options have us disabled - */ - if (isp->isp_osinfo.disabled) { - /* - * But return zero to preserve unit numbering - */ - return (0); - } - /* * Get PCI options- which in this case are just mapping preferences. */ diff --git a/sys/dev/isp/isp_sbus.c b/sys/dev/isp/isp_sbus.c index 4ef6da4e9cef..cb8f1698499b 100644 --- a/sys/dev/isp/isp_sbus.c +++ b/sys/dev/isp/isp_sbus.c @@ -155,19 +155,6 @@ isp_sbus_attach(device_t dev) sbs->sbus_dev = dev; sbs->sbus_mdvec = mdvec; - /* - * Figure out if we're supposed to skip this one. - * If we are, we actually go to ISP_ROLE_NONE. - */ - - tval = 0; - if (resource_int_value(device_get_name(dev), device_get_unit(dev), - "disable", &tval) == 0 && tval) { - device_printf(dev, "device is disabled\n"); - /* but return 0 so the !$)$)*!$*) unit isn't reused */ - return (0); - } - role = 0; if (resource_int_value(device_get_name(dev), device_get_unit(dev), "role", &role) == 0 &&