d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Relax time constraint in pthread_cond_timedwait unit test

Browse Source 
pthread_cond_timedwait() should wait _at least_ until the timeout,
but it might appear to wait longer due to system activity and
scheduling.  The test ignored fractional seconds when comparing the
actual and expected timeouts, so it allowed anywhere between zero
and one extra second of wait time.  Zero is a bit unreasonable.
Compare fractional seconds so we always allow up to one extra second.

Reviewed by:	ngie
MFC after:	1 week
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Eric van Gyzen 2019-08-05 22:59:35 +00:00
parent ed9ffd2f09
commit e48c002fa4
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
contrib/netbsd-tests/lib/libpthread/t_condwait.c
View File

@ -51,6 +51,9 @@ static void *
run(void *param)
{
struct timespec ts, to, te;
#ifdef __FreeBSD__
struct timespec tw;
#endif
clockid_t clck;
pthread_condattr_t attr;
pthread_cond_t cond;
@ -91,7 +94,15 @@ run(void *param)
/* Loose upper limit because of qemu timing bugs */
ATF_REQUIRE(to_seconds < WAITTIME * 2.5);
} else {
#ifdef __FreeBSD__
tw.tv_sec = WAITTIME;
tw.tv_nsec = 0;
ATF_REQUIRE(timespeccmp(&to, &tw, >=));
tw.tv_sec++;
ATF_REQUIRE(timespeccmp(&to, &tw, <=));
#else
ATF_REQUIRE_EQ(to.tv_sec, WAITTIME);
#endif
}
break;
default: