From e496f1c85594fb4608c60a04745733d028d12640 Mon Sep 17 00:00:00 2001 From: kib Date: Sun, 1 Nov 2020 16:38:30 +0000 Subject: [PATCH] net/if_media.c: improve IFMEDIA_DEBUG output. Use consistent output format for hex. Print both media and mask where relevant. Reviewed by: hselasky Sponsored by: Mellanox Technologies/NVidia Networking MFC after: 1 week Differential revision: https://reviews.freebsd.org/D27034 --- sys/net/if_media.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/net/if_media.c b/sys/net/if_media.c index 354a013e9848..1b06d51f3710 100644 --- a/sys/net/if_media.c +++ b/sys/net/if_media.c @@ -124,7 +124,7 @@ ifmedia_add(struct ifmedia *ifm, int mword, int data, void *aux) printf("ifmedia_add: null ifm\n"); return; } - printf("Adding entry for "); + printf("Adding entry for (%#010x) ", mword); ifmedia_printword(mword); } #endif @@ -229,8 +229,8 @@ ifmedia_ioctl(struct ifnet *ifp, struct ifreq *ifr, struct ifmedia *ifm, #ifdef IFMEDIA_DEBUG if (ifmedia_debug) { printf( - "ifmedia_ioctl: no media found for 0x%x\n", - newmedia); + "ifmedia_ioctl: no media found for %#010x mask %#010x\n", + newmedia, ifm->ifm_mask); } #endif return (ENXIO); @@ -337,7 +337,7 @@ ifmedia_match(struct ifmedia *ifm, int target, int mask) #if defined(IFMEDIA_DEBUG) || defined(DIAGNOSTIC) if (match) { printf("ifmedia_match: multiple match for " - "0x%x/0x%x\n", target, mask); + "%#010x/%#010x\n", target, mask); } #endif match = next;