d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use pessimal (u_short) types for i/o ports. This is mainly for

Browse Source 
completenss.  The pessimization is tiny compared with i/o port slowness
except on very old machines, but code that used signed short types for
i/o ports was unpessimized long ago, and the macro that detected it
recently started working for u_short types too.  Use of bus space
should have made this moot long ago.

Not tested at runtime by:  bde
This commit is contained in:
bde 2003-08-05 20:11:50 +00:00
parent 52bff5229a
commit e6b31b2814
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/digi/digi.h
View File

@ -152,8 +152,8 @@ struct digi_softc {
const char *name;
enum digi_board_status status;
ushort numports; /* number of ports on card */
ushort port; /* I/O port */
ushort wport; /* window select I/O port */
u_int port; /* I/O port */
u_int wport; /* window select I/O port */
struct {
struct resource *mem;

2
sys/i386/isa/if_rdp.c
View File

@ -121,7 +121,7 @@ struct rdp_softc {
/*
* local stuff, somewhat sorted by memory alignment class
*/
u_short baseaddr; /* IO port address */
u_int baseaddr; /* IO port address */
u_short txsize; /* tx size for next (buffered) packet,
* there's only one additional packet
* we can buffer, thus a single variable

2
sys/i386/isa/spic.c
View File

@ -97,7 +97,7 @@ static struct cdevsw spic_cdevsw = {
#define SCBUFLEN 128
struct spic_softc {
u_short sc_port_addr;
u_int sc_port_addr;
u_char sc_intr;
struct resource *sc_port_res,*sc_intr_res;
int sc_port_rid,sc_intr_rid;

2
sys/i386/isa/wt.c
View File

@ -157,7 +157,7 @@ typedef struct {
wtstatus_t error; /* status of controller */
unsigned short DATAPORT, CMDPORT, STATPORT, CTLPORT, SDMAPORT, RDMAPORT;
unsigned DATAPORT, CMDPORT, STATPORT, CTLPORT, SDMAPORT, RDMAPORT;
unsigned char BUSY, NOEXCEP, RESETMASK, RESETVAL;
unsigned char ONLINE, RESET, REQUEST, IEN;
} wtinfo_t;